Skip to content

[pyupgrade] Add fix safety section to docs (UP030) #17443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntBre merged 4 commits into from
Apr 21, 2025
Merged

[pyupgrade] Add fix safety section to docs (UP030) #17443

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eaa440a
add fix safety section to docs
Kalmaegi Apr 17, 2025
7f67c4a
adjust doc
Kalmaegi Apr 19, 2025
4af8224
adjust doc
Kalmaegi Apr 19, 2025
b630096
adjust doc
Kalmaegi Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/ruff_linter/src/rules/pyupgrade/rules/format_literals.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ use crate::Locator;
/// "{}, {}".format("Hello", "World") # "Hello, World"
/// ```
///
/// This fix is marked as unsafe because:
/// - Comments attached to arguments are not moved, which can cause comments to mismatch the actual arguments.
/// - If arguments have side effects (e.g., print), reordering may change program behavior.
///
/// ## References
/// - [Python documentation: Format String Syntax](https://docs.python.org/3/library/string.html#format-string-syntax)
/// - [Python documentation: `str.format`](https://docs.python.org/3/library/stdtypes.html#str.format)
Expand Down
Loading