[pyupgrade] Add fix safety section to docs (UP008, UP022)#17441
Merged
ntBre merged 1 commit intoastral-sh:mainfrom Apr 18, 2025
Conversation
ntBre
approved these changes
Apr 18, 2025
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Thanks! I think these are the only reasons these are unsafe, and I tested them in the playground to show that they both definitely delete comments.
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PERF403 | 12 | 6 | 6 | 0 | 0 |
| RUF043 | 2 | 2 | 0 | 0 | 0 |
pyupgrade] Add fix safety section to docs (UP008, UP022)
|
Chosing to myself for my boundary,no third party API , only me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add fix safety section to replace_stdout_stderr and super_call_with_parameters, for #15584
I checked the behavior and found that these two files could only potentially delete the appended comments, so I submitted them as a PR.