You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like the main reason for the regression is that we now see more deep_verified_memo calls compared to before. I'm a bit confused about this because the old code should already always have reached the deep_verify_memo (unless it panicked). The only thing I can think of is that we now run deep_verify_memo for provisional memos where we always returned Changed before... but wouldn't that lead to a perf improvement instead of a regression?
I'll merge this tomorrow. The salsa merge queue is too slow. If anyone wants this sooner. Feel free to update the Cargo.tomls with the commit hash from the salsa repo (tip of head)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Salsa to pull in salsa-rs/salsa#788 which fixes the, by now, famous access to field whilst the value is being initialized.
This PR also re-enables all tests that previously triggered the panic.
Test Plan
cargo test