[red-knot] update to latest Salsa with fixpoint caching fix#17179
Merged
[red-knot] update to latest Salsa with fixpoint caching fix#17179
Conversation
Contributor
|
carljm
changed the title
MichaReiser
approved these changes
Apr 3, 2025
Member
|
How long before @sharkdp adds new projects to our mypy primer run? :) |
Member
|
I shall put in my bet at "7 minutes" |
Contributor
Author
I think the projects that no longer hang still panic at the moment, that's next on my list... |
Member
|
Ah yes, I see we still panic on pylint with this fix landed (twice, in fact!), but we now promptly finish the process after panicking, whereas previously we panicked and then... hung around for ages before finishing the process 😄 Progress! |
dcreager
added a commit
that referenced
this pull request
Apr 3, 2025
* origin/main: [red-knot] Add `Type::TypeVar` variant (#17102) [red-knot] update to latest Salsa with fixpoint caching fix (#17179) Upgrade to Rust 1.86 and bump MSRV to 1.84 (#17171) [red-knot] Avoid unresolved-reference in unreachable code (#17169) Fix relative import resolution in `site-packages` packages when the `site-packages` search path is a subdirectory of the first-party search path (#17178) [DO NOT LAND] bump Salsa version (#17176) [syntax-errors] Detect duplicate keys in `match` mapping patterns (#17129)
maxmynter
pushed a commit
to maxmynter/ruff
that referenced
this pull request
Apr 3, 2025
…h#17179) With this PR, we no longer "hang" (not actually a hang, just an explosion in execution time) when checking pylint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, we no longer "hang" (not actually a hang, just an explosion in execution time) when checking pylint.