[red-knot] support narrowing on or patterns in matches #17030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmarkmartin
requested review from
carljm,
AlexWaygood,
sharkdp and
dcreager
as code owners
|
Move the pattern guard field from PatternPredicateKind to PatternPredicate. This better matches the ast and saves us from storing a bunch of Nones in or patterns. Also, it will make things a bit cleaner if we start to look at guards in the match case narrowing
sharkdp
reviewed
Mar 28, 2025
| case "foo" | 42 | None: | ||
| reveal_type(x) # revealed: Literal["foo", 42] | None | ||
| case "foo" | tuple(): | ||
| # kill lamumbo |
There was a problem hiding this comment.
Has this been randomly generated by an LLM or what is going on?
There was a problem hiding this comment.
I'm also curious how this came to be here 😆 but the PR looks great otherwise, so I'm just going to remove this line and merge.
carljm
approved these changes
Mar 28, 2025
| case "foo" | 42 | None: | ||
| reveal_type(x) # revealed: Literal["foo", 42] | None | ||
| case "foo" | tuple(): | ||
| # kill lamumbo |
There was a problem hiding this comment.
I'm also curious how this came to be here 😆 but the PR looks great otherwise, so I'm just going to remove this line and merge.
crates/red_knot_python_semantic/resources/mdtest/narrow/match.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #13694
Narrow in or-patterns by taking the type union of the type constraints in each disjunct pattern.
Test Plan
Add new tests to narrow/match.md