[flake8-todos] Allow VSCode GitHub PR extension style links in missing-todo-link (TD003)
#15519
+49
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylwil3
added
rule
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| TD003 | 28 | 0 | 28 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -28 violations, +0 -0 fixes in 4 projects; 51 projects unchanged)
apache/airflow (+0 -8 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- kubernetes_tests/test_kubernetes_pod_operator.py:1402:3: TD003 Missing issue link on the line following this TODO - providers/src/airflow/providers/google/cloud/sensors/tasks.py:81:11: TD003 Missing issue link on the line following this TODO - providers/src/airflow/providers/http/hooks/http.py:310:11: TD003 Missing issue link on the line following this TODO - task_sdk/src/airflow/sdk/definitions/_internal/abstractoperator.py:329:19: TD003 Missing issue link on the line following this TODO - task_sdk/src/airflow/sdk/execution_time/task_runner.py:505:11: TD003 Missing issue link on the line following this TODO - task_sdk/src/airflow/sdk/execution_time/task_runner.py:506:11: TD003 Missing issue link on the line following this TODO - task_sdk/tests/defintions/_internal/test_templater.py:58:11: TD003 Missing issue link on the line following this TODO - tests/ti_deps/deps/test_mapped_task_upstream_dep.py:156:29: TD003 Missing issue link on the line following this TODO
apache/superset (+0 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- superset/sql_parse.py:87:3: TD003 Missing issue link on the line following this TODO
bokeh/bokeh (+0 -18 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- src/bokeh/layouts.py:361:3: TD003 Missing issue link on the line following this TODO - src/bokeh/resources.py:247:3: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_color_picker.py:107:11: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_daterange_slider.py:169:13: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_daterange_slider.py:192:11: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_dateslider.py:163:11: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_dateslider.py:197:11: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_dateslider.py:220:11: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_dateslider.py:243:11: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_range_slider.py:220:11: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_range_slider.py:243:11: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_slider.py:186:11: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_slider.py:220:11: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_slider.py:243:11: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_slider.py:266:11: TD003 Missing issue link on the line following this TODO - tests/integration/widgets/test_spinner.py:228:11: TD003 Missing issue link on the line following this TODO - tests/support/plugins/project.py:162:15: TD003 Missing issue link on the line following this TODO - tests/unit/bokeh/server/views/test_multi_root_static_handler.py:45:50: TD003 Missing issue link on the line following this TODO
zulip/zulip (+0 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- zerver/lib/message_cache.py:452:15: TD003 Missing issue link on the line following this TODO
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| TD003 | 28 | 0 | 28 | 0 | 0 |
I edited your PR message so that the commit should show up as co-authored by Martin if this PR is merged :-) |
Perfect, I was just looking up how to do that! |
|
In other news, these ecosystem checks look correct to me. All of these folks dutifully putting issue links in their TODOs and getting yelled at by TD003... such injustice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow links to issues that appear on the same line as the TODO directive, if they conform to the format that VSCode's GitHub PR extension produces.
Revival of #9627 (the branch was stale enough that rebasing was a lot harder than just making the changes anew). Credit should go to the author of that PR though.
Closes #8061
Co-authored-by: Martin Bernstorff [email protected]