Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8-bandit] Check for builtins instead of builtin (S102, PTH123) #15443

Merged
merged 2 commits into from
Jan 13, 2025
Merged

[flake8-bandit] Check for builtins instead of builtin (S102, PTH123) #15443

merged 2 commits into from
Jan 13, 2025

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #15442.

Test Plan

cargo nextest run and cargo insta test.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@InSyncWithFoo
Copy link
Contributor Author

Should these rules be renamed as well?

charliermarsh
charliermarsh approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh added the bug Something isn't working label Jan 13, 2025
@charliermarsh charliermarsh merged commit 4f37fde into astral-sh:main Jan 13, 2025
21 checks passed
@InSyncWithFoo InSyncWithFoo deleted the S102 branch January 13, 2025 00:56
@BrewTestBot BrewTestBot mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PTH123 and S102 check builtin instead of builtins
2 participants
@InSyncWithFoo @charliermarsh