Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Understand typing.Tuple #14927

Merged
merged 2 commits into from
Dec 12, 2024
Merged

[red-knot] Understand typing.Tuple #14927

merged 2 commits into from
Dec 12, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #14916.

Test Plan

Markdown tests.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

AlexWaygood
AlexWaygood reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@AlexWaygood AlexWaygood merged commit e4885a2 into astral-sh:main Dec 12, 2024
21 checks passed
@InSyncWithFoo InSyncWithFoo deleted the rk-typing-tuple branch December 12, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[red-knot] Understand typing.Tuple
2 participants
@InSyncWithFoo @AlexWaygood