Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): add missing flake8-simplify #1449

Merged
merged 1 commit into from
Dec 29, 2022
Merged

docs(README): add missing flake8-simplify #1449

merged 1 commit into from
Dec 29, 2022

Conversation

mkniewallner
Copy link
Contributor

Noticed that flake8-simplify is mentioned here, but not in the list of tools that ruff can replace.

I based the total number of rules on what's listed in https://github.com/MartinThoma/flake8-simplify#rules (without the "legacyfix" and "removed" ones) and included the experimental rules (SIM9), but if you prefer not to include the experimental ones, it totals to 30 rules.

@charliermarsh
Copy link
Member

I think I omitted it initially because we'd only done one rule so far, but this is also fine :)

@charliermarsh
Copy link
Member

Somehow I got 33 rules when I created the table here -- is the discrepancy obvious to you? Is that table missing some, or the other way around?

@mkniewallner
Copy link
Contributor Author

I think I omitted it initially because we'd only done one rule so far, but this is also fine :)

Ha, I was wondering if it was intentional or not, but since there are other plugins listed with only 1 rule (autoflake and flake8-tidy-imports, although they have way less total rules), I wasn't sure.

Somehow I got 33 rules when I created the table here -- is the discrepancy obvious to you? Is that table missing some, or the other way around?

Differences I can see:

  • SIM104 is in the list, and I didn't count it as it is listed as a "legacyfix"
  • SIM224 is in the list, but it's a placeholder for an experimental rule
  • SIM124 is in the list, but it's a placeholder for an experimental rule

@mkniewallner
Copy link
Contributor Author

The list also doesn't include experimental rules under SIM9 (although it's probably intended), so without the 3 extra rules, it totals to 30 (and 37 if we count the experimental ones).

@charliermarsh
Copy link
Member

Ok cool -- let's go with your list, those explanations make sense! I'll merge and edit the issue.

@charliermarsh charliermarsh merged commit 02f156c into astral-sh:main Dec 29, 2022
@mkniewallner mkniewallner deleted the docs/add-missing-flake8-simplify-readme branch December 29, 2022 22:04
renovate bot referenced this pull request in ixm-one/pytest-cmake-presets Dec 30, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://github.com/charliermarsh/ruff) | `^0.0.200` ->
`^0.0.201` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.201/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.201/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.201/compatibility-slim/0.0.200)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.201/confidence-slim/0.0.200)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.201`](https://github.com/charliermarsh/ruff/releases/tag/v0.0.201)

[Compare
Source](https://github.com/charliermarsh/ruff/compare/v0.0.200...v0.0.201)

#### What's Changed

- Rename config to settings in the playground by
[@&#8203;charliermarsh](https://github.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1450](https://github.com/charliermarsh/ruff/pull/1450)
- docs(README): add missing `flake8-simplify` by
[@&#8203;mkniewallner](https://github.com/mkniewallner) in
[https://github.com/charliermarsh/ruff/pull/1449](https://github.com/charliermarsh/ruff/pull/1449)
- Add Sphinx to user list by
[@&#8203;AA-Turner](https://github.com/AA-Turner) in
[https://github.com/charliermarsh/ruff/pull/1451](https://github.com/charliermarsh/ruff/pull/1451)
- Move default options into WASM interface by
[@&#8203;charliermarsh](https://github.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1453](https://github.com/charliermarsh/ruff/pull/1453)
- Implement dark mode by
[@&#8203;charliermarsh](https://github.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1455](https://github.com/charliermarsh/ruff/pull/1455)
- Use trailingComma: 'all' by
[@&#8203;charliermarsh](https://github.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1457](https://github.com/charliermarsh/ruff/pull/1457)
- Remove generated TypeScript options by
[@&#8203;charliermarsh](https://github.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1456](https://github.com/charliermarsh/ruff/pull/1456)
- Copy URL but don't update the hash by
[@&#8203;charliermarsh](https://github.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1458](https://github.com/charliermarsh/ruff/pull/1458)
- Removed unicode literals by
[@&#8203;colin99d](https://github.com/colin99d) in
[https://github.com/charliermarsh/ruff/pull/1448](https://github.com/charliermarsh/ruff/pull/1448)
- Implement TID251 (banning modules & module members) by
[@&#8203;not-my-profile](https://github.com/not-my-profile) in
[https://github.com/charliermarsh/ruff/pull/1436](https://github.com/charliermarsh/ruff/pull/1436)
- Implicit flake8-implicit-str-concat by
[@&#8203;charliermarsh](https://github.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1463](https://github.com/charliermarsh/ruff/pull/1463)

#### New Contributors

- [@&#8203;mkniewallner](https://github.com/mkniewallner) made their
first contribution in
[https://github.com/charliermarsh/ruff/pull/1449](https://github.com/charliermarsh/ruff/pull/1449)
- [@&#8203;AA-Turner](https://github.com/AA-Turner) made their first
contribution in
[https://github.com/charliermarsh/ruff/pull/1451](https://github.com/charliermarsh/ruff/pull/1451)
- [@&#8203;not-my-profile](https://github.com/not-my-profile) made
their first contribution in
[https://github.com/charliermarsh/ruff/pull/1436](https://github.com/charliermarsh/ruff/pull/1436)

**Full Changelog**:
astral-sh/ruff@v0.0.200...v0.0.201

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNzQuMiJ9-->

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants