Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8-simplify] Infer "unknown" truthiness for literal iterables whose items are all unpacks (SIM222) #14263

Merged
merged 3 commits into from
Nov 11, 2024
Merged

[flake8-simplify] Infer "unknown" truthiness for literal iterables whose items are all unpacks (SIM222) #14263

merged 3 commits into from
Nov 11, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #14237.

Test Plan

cargo nextest run and cargo insta test.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

dhruvmanila
dhruvmanila approved these changes Nov 11, 2024
View reviewed changes
crates/ruff_python_ast/src/helpers.rs Outdated Show resolved Hide resolved
crates/ruff_python_ast/src/helpers.rs Outdated Show resolved Hide resolved
@dhruvmanila dhruvmanila added the bug Something isn't working label Nov 11, 2024
@charliermarsh charliermarsh merged commit be69f61 into astral-sh:main Nov 11, 2024
20 checks passed
@InSyncWithFoo InSyncWithFoo deleted the SIM222 branch November 11, 2024 20:38
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIM222 false positive in [*iterable] or [another list]
3 participants
@InSyncWithFoo @dhruvmanila @charliermarsh