Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using typing.Self in stub files pre-Python 3.11 #14230

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Avoid using typing.Self in stub files pre-Python 3.11 #14230

merged 1 commit into from
Nov 9, 2024

Conversation

charliermarsh
Copy link
Member

Summary

See: #14217 (comment).

This means we're recommending typing_extensions in non-stubs pre-3.11, which may not be a valid project dependency, but that's a separate issue (#9761).

@charliermarsh charliermarsh added the bug Something isn't working label Nov 9, 2024
@charliermarsh charliermarsh requested review from AlexWaygood and removed request for AlexWaygood November 9, 2024 17:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@AlexWaygood
Copy link
Member

Thanks!

@charliermarsh charliermarsh merged commit 1279c20 into main Nov 9, 2024
20 checks passed
@charliermarsh charliermarsh deleted the charlie/self branch November 9, 2024 18:17
@charliermarsh
Copy link
Member Author

Thank you!

@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliermarsh @AlexWaygood