Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pyupgrade] - ignore kwarg unpacking for UP044 #14053

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

diceroll123
Copy link
Contributor

Summary

Fixes #14047

Test Plan

catgo test

Copy link
Contributor

github-actions bot commented Nov 1, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -18 violations, +0 -0 fixes in 1 projects; 53 projects unchanged)

rotki/rotki (+0 -18 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- rotkehlchen/db/cache.py:73:36: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/cache.py:77:36: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/cache.py:81:36: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/cache.py:85:36: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:699:23: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:708:23: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:717:23: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:726:23: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:735:23: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:744:23: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:753:23: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:776:23: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:786:23: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:796:23: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:806:23: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:816:23: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:826:23: UP044 [*] Use `*` for unpacking
- rotkehlchen/db/dbhandler.py:836:23: UP044 [*] Use `*` for unpacking

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
UP044 18 0 18 0 0

@charliermarsh charliermarsh added the bug Something isn't working label Nov 2, 2024
@charliermarsh charliermarsh merged commit 0925513 into astral-sh:main Nov 2, 2024
20 checks passed
@MichaReiser
Copy link
Member

Hmm, I should have spotted this in the ecosystem checks. Thanks for fixing this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UP044 false positive around PEP 692 TypedDict **kwargs type hints
3 participants