Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ipytest cell magic #13745

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Allow ipytest cell magic #13745

merged 1 commit into from
Oct 14, 2024

Conversation

dhruvmanila
Copy link
Member

Summary

fixes: #13718

Test Plan

Using the notebook as mentioned in #13718 (comment), this PR does not give the "F821 Undefined name test_sorted" diagnostic.

@dhruvmanila dhruvmanila added the bug Something isn't working label Oct 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser
Copy link
Member

Thanks

@dhruvmanila dhruvmanila merged commit 5caabe5 into main Oct 14, 2024
20 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/ipytest-magic branch October 14, 2024 10:18
@BrewTestBot BrewTestBot mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive F401 due to %%ipytest line in notebook
2 participants
@dhruvmanila @MichaReiser