Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use backticks for code in red-knot messages #13599

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Oct 2, 2024

Summary

...and remove periods from messages that don't span more than a single sentence.

This is more consistent with how we present user-facing messages in uv (which has a defined style guide).

@charliermarsh
Copy link
Member Author

I might also suggest removing periods from the end of these error messages (unless they span more than one sentence). We use that policy in uv and in Ruff.

Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have no problem with removing final periods, in this PR or another one; it makes sense to have a consistent style guide across projects.

@carljm
Copy link
Contributor

carljm commented Oct 2, 2024

Looks like there's one missed test to fix.

@charliermarsh
Copy link
Member Author

Sounds good. I'll probably just bundle it here then to reduce churn (fewer commits to ignore when git blaming).

@charliermarsh charliermarsh force-pushed the charlie/ticks branch 2 times, most recently from 5e35760 to d82e2b3 Compare October 2, 2024 02:48
Copy link
Contributor

github-actions bot commented Oct 2, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh charliermarsh enabled auto-merge (squash) October 2, 2024 03:10
@charliermarsh charliermarsh merged commit c3b40da into main Oct 2, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/ticks branch October 2, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants