[pylint] Recurse into subscript subexpressions when searching for list/dict lookups (PLR1733, PLR1736)

[AlexWaygood]

Summary

The SequenceIndexVisitor currently does not recurse into subexpressions of subscripts when searching for subscript accesses that would trigger this rule. That means that we don't currently detect violations of the rule on snippets like this:

data = {"a": 1, "b": 2}
column_names = ["a", "b"]
for index, column_name in enumerate(column_names):
    _ = data[column_names[index]]

Fixes #13183

Test Plan

cargo test -p ruff_linter

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+2 -0 violations, +0 -0 fixes in 1 projects; 53 projects unchanged)

zulip/zulip (+2 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ analytics/views/stats.py:623:51: PLR1733 [*] Unnecessary lookup of dictionary value by key
+ analytics/views/stats.py:625:44: PLR1733 [*] Unnecessary lookup of dictionary value by key

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
PLR1733	2	2	0	0	0

[AlexWaygood]

ℹ️ ecosystem check detected linter changes. (+2 -0 violations, +0 -0 fixes in 1 projects; 53 projects unchanged)
zulip/zulip (+2 -0 violations, +0 -0 fixes)

Nice, it looks like this also fixes false negatives in other rules that use this visitor

[sbrugman]

LGTM. Thanks for the quick PR :)