[red-knot] refactor CFG outside of symbol table #11746
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Separate SymbolTable and FlowGraph into their own modules, and make both submodules of
red_knot::semantic
module. Also movetypes
module intosemantic
.red_knot::semantic::SemanticIndexer
builds aSemanticIndex
(consisting of the symbol table and flow graph). Thesymbol_table
query is nowsemantic_index
, andSymbolTablesStorage
isSemanticIndexStorage
.Both
SymbolTable
andFlowGraph
are immutable, and constructed using a separate builder.Fixes #11657.
Test Plan
Refactor; existing tests pass.