Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff server: Editor settings are used by default if no file-based configuration exists #11266

Merged
merged 1 commit into from
May 4, 2024

Conversation

snowsignal
Copy link
Contributor

Summary

Fixes #11258.

This PR fixes the settings resolver to match the expected behavior when file-based configuration is not available.

Test Plan

In a workspace with no file-based configuration, set a setting in your editor and confirm that this setting is used instead of the default.

@snowsignal snowsignal added bug Something isn't working server Related to the LSP server labels May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@snowsignal snowsignal merged commit c4bf783 into main May 4, 2024
19 checks passed
@snowsignal snowsignal deleted the jane/server/merge-fallback-settings branch May 4, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server Related to the LSP server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ruff server does not merge editor settings with fallback settings
2 participants