Omit repeated equality comparison for sys #10054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| let excluder = Regex::new(r"^(platform|version)").unwrap(); | ||
| return !excluder.is_match(left.clone().expect_attribute_expr().attr.as_str()); | ||
| } |
There was a problem hiding this comment.
Thanks! Can you try something like:
any_over_expr(test, &|expr| {
semantic.resolve_call_path(expr).is_some_and(|call_path| {
matches!(call_path.as_slice(), ["sys", "version_info" | "platform"])
})
})This is roughly taken from a helper we have called is_sys_version_block.
charliermarsh
requested changes
Feb 20, 2024
charliermarsh
approved these changes
Feb 20, 2024
|
|
Sorry, I couldn't get to this in time. Thank you! |
|
No prob, I was just in PR-closing-mode and took advantage of being in the area. Thanks for contributing! |
nkxxll
pushed a commit
to nkxxll/ruff
that referenced
this pull request
Mar 10, 2024
## Summary Update PLR1714 to ignore `sys.platform` and `sys.version` checks. I'm not sure if these checks or if we need to add more. Please advise. Fixes astral-sh#10017 ## Test Plan Added a new test case and ran `cargo nextest run`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update PLR1714 to ignore
sys.platformandsys.versionchecks.I'm not sure if these checks or if we need to add more. Please advise.
Fixes #10017
Test Plan
Added a new test case and ran
cargo nextest run