-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatter: Match
(includes MatchCase
and Patterns
)
#5834
Comments
As a note. The idea isn't that this is all implemented in a single PR. I recommend to start implementing |
Regarding the match patterns, I would say that |
I can take those pattern issues! Feel free to assign them to me |
Awesome. Let's start with one to leave an opportunity for other contributors too. Can you pick one and comment on the issue so that I can assign it to you? |
I don't think this is ready yet. We first need to land #6594 (@evanrittenhouse you can work on top of that PR, as long as you don't mind that there's one failing test). |
Is #6933 still required for the Alpha release? Looks like it’s marked as Beta. |
My impression is that #6933 shouldn't be blocking for alpha. |
This is a bigger project that includes the following nodes:
StmtMatch
#6298MatchCase
#6299PatternMatchAs
#6641PatternMatchClass
#6642PatternMatchMapping
#6644PatternMatchOr
#6643PatternMatchSequence
#6645PatternMatchSingleton
#6557PatternMatchStar
#6558PatternMatchValue
#6555The match arms have the same considerations for comments as if branches or try-except branches.
The text was updated successfully, but these errors were encountered: