[feature] Differentiate between safe and unsafe fixes #4181
Comments
MichaReiser
changed the title
|
@MichaReiser You can assign this to me, I'd like to take it to completion if it's open! |
Hey @evanrittenhouse. Do you plan to work on all of it or individual sub-tasks? |
|
From what I can tell, @zanieb has done quite a bit of progress on #4276 already. I'd happily take on #4184 - 87 though (and 76, if Zanie doesn't want to do it anymore). I have a draft PR for #4185 out already that hinges upon the completion of #4184, so I'm trying to knock that out. There's a list of the remaining linters that have |
Following much discussion for #4181 at #5119, #5476, #7769, #7819, and in [Discord](https://discord.com/channels/1039017663004942429/1082324250112823306/1159144114231709746), this pull request changes `Applicability` from using `Automatic`, `Suggested`, and `Manual` to `Always`, `Sometimes`, and `Never`. Also removes `Applicability::Unspecified` (replacing #7792).
Following much discussion for #4181 at #5119, #5476, #7769, #7819, and in [Discord](https://discord.com/channels/1039017663004942429/1082324250112823306/1159144114231709746), this pull request changes `Applicability` from using `Automatic`, `Suggested`, and `Manual` to `Always`, `Sometimes`, and `Never`. Also removes `Applicability::Unspecified` (replacing #7792).
|
@zanieb should we close this issue? I'm okay deferring the add "message to fix" for now as it also is somewhat unrelated to the applicability work. |
This task tracks the work implementing safe and unsafe fixes as described in #1997.
Safe fixes are fixes that don't change the semantics of the program. Unsafe fixes may change the program's semantics; therefore, we advise users to manually review and test the changes.
Tasks
FixandEditAPI #4182ApplicabilitytoFix#4183Applicabilityin JSON output #4340Fixconstructor #4276fixesassafeormaybe_incorrect#4184Applicability#4185Applicabilityin LSP #4186Applicabilityin Diagnostics #4187The text was updated successfully, but these errors were encountered: