Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename rules according to naming convention #2902

Closed
2 of 5 tasks
Tracked by #1773
not-my-profile opened this issue Feb 14, 2023 · 2 comments · Fixed by #3661
Closed
2 of 5 tasks
Tracked by #1773

Rename rules according to naming convention #2902

not-my-profile opened this issue Feb 14, 2023 · 2 comments · Fixed by #3661

Comments

@not-my-profile
Copy link
Contributor

not-my-profile commented Feb 14, 2023 •
edited by charliermarsh
Loading

This is the tracking issue for our effort to rename our rules according to our rule naming convention.

Some related renaming efforts:

  • We want to prefix pytest-* to all pytest-style rule names.
  • We want to prefix pandas- to all pandas-vet rule names.

See also #2714.
@charliermarsh
Copy link
Member

I also added numpy-* to the NumPy-specific rules.

@ngnpope ngnpope mentioned this issue Feb 15, 2023
Merged
@charliermarsh
Copy link
Member

I'm gonna try and do a pass on all rules and propose the changes here.

charliermarsh pushed a commit that referenced this issue Feb 26, 2023
@ngnpope
Rename some flake8-simplify rules (#2915)
994e2e0 
Renames the following rules that stood out to me at a glance as needing better names:

- `or-true` to `expr-or-true`
- `and-false` to `expr-and-false`
- `a-or-not-a` to `expr-or-not-expr`
- `a-and-not-a` to `expr-and-not-expr`

Related to #2902.
@charliermarsh charliermarsh mentioned this issue Feb 28, 2023
Merged
@not-my-profile not-my-profile mentioned this issue Mar 7, 2023
Open
1 task
This was referenced Mar 22, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename remaining use-* rules astral-sh/ruff
2 participants
@charliermarsh @not-my-profile