Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autofix for "unused variable" #1460

Closed
charliermarsh opened this issue Dec 30, 2022 · 1 comment · Fixed by #1683
Closed

Add autofix for "unused variable" #1460

charliermarsh opened this issue Dec 30, 2022 · 1 comment · Fixed by #1683
Assignees
@charliermarsh
Labels
fixes Related to suggested fixes for violations

Comments

@charliermarsh
Copy link
Member

charliermarsh commented Dec 30, 2022 •
edited
Loading

To start, we can just mimic autoflake, whose logic is relatively simple: https://github.com/PyCQA/autoflake/blob/60eeb31082bf5290341e84a008d5c832fb04fd13/autoflake.py#L664.
@charliermarsh charliermarsh added the good first issue Good for newcomers label Dec 30, 2022
@charliermarsh
Copy link
Member Author

(Not "trivial" but could be a good first issue if anyone's interested given that the autoflake logic can mostly be ported over.)

@charliermarsh charliermarsh mentioned this issue Dec 30, 2022
Closed
@charliermarsh charliermarsh added fixes Related to suggested fixes for violations and removed enhancement labels Dec 31, 2022
@charliermarsh charliermarsh self-assigned this Jan 6, 2023
@charliermarsh charliermarsh removed the good first issue Good for newcomers label Jan 6, 2023
@charliermarsh charliermarsh mentioned this issue Jan 6, 2023
Merged
charliermarsh added a commit that referenced this issue Jan 7, 2023
@charliermarsh
Automatically remove unused variables (#1683)
0527fb9 
Closes #1460.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automatically remove unused variables astral-sh/ruff
1 participant
@charliermarsh