Declare support for TOML files - #1127
Merged
Merged
Conversation
Summary -- Related to astral-sh/ruff#26862. I copied the Markdown changes from #950. Closes astral-sh/ruff#27088. Test Plan -- <!-- TODO screenshot of VS Code -->
ntBre
commented
Jul 30, 2026
| { scheme: "vscode-notebook-cell", language: "python" }, | ||
| { scheme: "file", language: "markdown" }, | ||
| { scheme: "untitled", language: "markdown" }, | ||
| { scheme: "file", pattern: "**/{pyproject.toml,ruff.toml,.ruff.toml}" }, |
Contributor
Author
There was a problem hiding this comment.
Codex says that this also registers Ruff as a TOML formatter but that fixing this is not simple and should be a follow-up. It also shouldn't prevent users from selecting/configuring an actual TOML formatter, it just shows Ruff as an additional option.
Member
There was a problem hiding this comment.
Can't we change for which documents the LSP registers formatting support
Contributor
Author
There was a problem hiding this comment.
Sounds like the answer is yes, but Codex says that fix is back in ruff_server, not here. I'll see what that looks like.
Member
There was a problem hiding this comment.
Yes, the fix is in ruff_server.
MichaReiser
approved these changes
Jul 31, 2026
ntBre
added a commit
to astral-sh/ruff
that referenced
this pull request
Jul 31, 2026
…27332) Summary -- Addresses astral-sh/ruff-vscode#1127 (comment), which would otherwise expose Ruff as a TOML formatter in VS Code. Instead of registering formatting and range formatting capabilities statically, we now register them dynamically only for Python, Markdown, and notebook files, excluding TOML files. We still fall back on static registration if dynamic registration is unavailable. Test Plan -- New e2e tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to astral-sh/ruff#26862. I copied the Markdown changes from #950.
Closes astral-sh/ruff#27088.
Test Plan