feat: use uv for package management #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Mar 23, 2024
`uv` should be used to install all required packages. However, you need to have `uv` installed first. Meaning, you end up in a circle dependency. While this should not result in any issues, this commit is to help ensure that. The main motivation for this: #77 (comment) In development, you only need `uv` for compiling the `requirements-dev.txt` file.
zanieb
reviewed
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
uvis great. So we should use it where we can.The cache had to be removed because the workflow breaks currently. actions/setup-python#822
When this is solved, caching can be brought back in.
Test Plan
Ran workflow on my local repo.