Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changed-files for cases where no python files changed #4

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix changed-files for cases where no python files changed #4

merged 2 commits into from
Sep 30, 2024

Conversation

DavidJFelix
Copy link
Contributor

Problem

When a PR contains no changed python files, but changed-files is set to true, ruff will run on all files, including ones not changed.

Solution

Pass the input through to the script and short circuit to success in cases where both the flag is set and no python files were changed.

@DavidJFelix
Copy link
Contributor Author

Linking old PR from pre-fork repo: ChartBoost/ruff-action#29

@charliermarsh charliermarsh merged commit 61703ed into astral-sh:main Sep 30, 2024
1 check passed
@charliermarsh charliermarsh added the bug Something isn't working label Sep 30, 2024
@charliermarsh
Copy link
Member

Thanks!

@DavidJFelix DavidJFelix deleted the fix-changed branch September 30, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants