Skip to content

Exercise tests_curses_interactive in CI #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Exercise tests_curses_interactive in CI #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ea2b26
run validation unit tests with verbose flag
jjhelmus Oct 29, 2025
fa4c38c
TST: try validation with xterm
jjhelmus Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,3 +417,4 @@ jobs:
env:
MATRIX_RUN: ${{ matrix.run }}
MATRIX_LIBC: ${{ matrix.libc }}
TERM: xterm
25 changes: 14 additions & 11 deletions src/validation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2237,17 +2237,20 @@ fn verify_distribution_behavior(dist_path: &Path) -> Result<Vec<String>> {
std::fs::write(&test_file, PYTHON_VERIFICATIONS.as_bytes())?;

eprintln!(" running interpreter tests (output should follow)");
let output = duct::cmd(&python_exe, [test_file.display().to_string()])
.stdout_to_stderr()
.unchecked()
.env("TARGET_TRIPLE", &python_json.target_triple)
.env("BUILD_OPTIONS", &python_json.build_options)
.run()
.context(format!(
"Failed to run `{} {}`",
python_exe.display(),
test_file.display()
))?;
let output = duct::cmd(
&python_exe,
[test_file.display().to_string(), "-v".to_string()],
Copy link
Member

@zanieb zanieb Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we revert the -v change or no?

)
.stdout_to_stderr()
.unchecked()
.env("TARGET_TRIPLE", &python_json.target_triple)
.env("BUILD_OPTIONS", &python_json.build_options)
.run()
.context(format!(
"Failed to run `{} {}`",
python_exe.display(),
test_file.display()
))?;

if !output.status.success() {
errors.push("errors running interpreter tests".to_string());
Expand Down