Conversation
geofft
left a comment
There was a problem hiding this comment.
LGTM, should we add a test for this? The one I came up with is
$ uvx python@3.14b4
Python 3.14.0b4 (main, Jul 8 2025, 21:00:06) [Clang 20.1.4 ] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import sqlite3
>>> s = sqlite3.connect(":memory:")
>>> c = s.cursor()
>>> c.execute("CREATE VIRTUAL TABLE email USING fts5(sender, title, body);")
Traceback (most recent call last):
File "<python-input-3>", line 1, in <module>
c.execute("CREATE VIRTUAL TABLE email USING fts5(sender, title, body);")
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
sqlite3.OperationalError: no such module: fts5
Should we care about these other extensions too? |
|
Yeah it makes sense to enable anything that's common in the wild. A test seems reasonable, do you want to add it? |
|
Looks like there's some tests already. Since this is my first time actually running them, I'm going to let CI chew on this to make sure the tests fail on the full matrix, and then I'll push the #defines to fix it. |
|
We could really use this fix, our project is broken without fts5. basicmachines-co/basic-memory#225 |
|
To add more context, I'm running on OS X and fts5 is currently broken, as of a couple days ago sqlite_test.py output: |
This is primarily a regression fix for missing SQLite extensions (astral-sh/python-build-standalone#694).
|
Sorry about the trouble - the 20250712 release is out now with these extension modules present. I opened astral-sh/uv#14578 to get these picked up in uv, I'd expect a new version by early next week if not sooner. |
) This is primarily a regression fix for missing SQLite extensions (astral-sh/python-build-standalone#694).
|
uv 0.7.21 is out with these fixes. If you have uv 0.7.20 installed please run |
No description provided.