Skip to content

Avoid term lookups when merging dependencies - #69

Closed
charliermarsh wants to merge 1 commit into
mainfrom
charlie/direct-dependency-merge
Closed

Avoid term lookups when merging dependencies#69
charliermarsh wants to merge 1 commit into
mainfrom
charlie/direct-dependency-merge

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Jun 29, 2026

Copy link
Copy Markdown
Member

Summary

The merged-dependency hash index narrows each candidate search to incompatibilities with the same dependent package, dependency package, and dependency-range hash. merge_dependents then reconstructs those same ranges through four SmallMap lookups and positive/negative Term unwrapping before it can compare and merge them.

This change destructures the two FromDependencyOf kinds once, compares their stored dependency ranges directly to retain collision safety, and unions their stored dependent ranges. The self-dependency and package-identity guards are unchanged. The old negative-term unwrapping helper becomes unused and is removed.

@codspeed-hq

codspeed-hq Bot commented Jun 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing charlie/direct-dependency-merge (6dd7ca3) with main (cfe9498)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant