Merged
Conversation
The semver checks flagged adding a new error variant as a breaking change. This is correct, but don't actually want to guarantee exhaustiveness, you should be able to check for specific error variants downstream to specialize the error message, but you shouldn't try to match exhaustively, the error representation isn't that stable. Other crates hide the error type altogether, but that's a bad experience as a user, I ran into problems with this before.
konstin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The semver checks flagged adding a new error variant as a breaking change. This is correct, but don't actually want to guarantee exhaustiveness, you should be able to check for specific error variants downstream to specialize the error message, but you shouldn't try to match exhaustively, the error representation isn't that stable. Other crates hide the error type altogether, but that's a bad experience as a user, I ran into problems with this before.