Fixed invalid PMT and PAT version increments #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asticode
force-pushed
the
version-number
branch
from
74bcbe8 to
e6fbae1
Compare
barbashov
reviewed
Mar 18, 2022
| @@ -52,11 +53,18 @@ func TestMuxer_generatePAT(t *testing.T) { | |||
| assert.Equal(t, MpegTsPacketSize, muxer.patBytes.Len()) | |||
| assert.Equal(t, patExpectedBytes(0, 0), muxer.patBytes.Bytes()) | |||
|
|
|||
| // to check version number increment | |||
| // Version number shouldn't change | |||
There was a problem hiding this comment.
It would be great to do the same test for PMT. Otherwise the code looks good :)
There was a problem hiding this comment.
you're right I've added the same test for PMT 👍
There was a problem hiding this comment.
I think now it's ready to merge :)
There was a problem hiding this comment.
Oh, you've done it already :)
asticode
force-pushed
the
version-number
branch
from
e6fbae1 to
e986edc
Compare
aler9
added a commit
to bluenviron/mediamtx
that referenced
this pull request
Apr 21, 2022
JoMallari98
pushed a commit
to JoMallari98/rtsp-server
that referenced
this pull request
Feb 25, 2023
eliteprodev
pushed a commit
to eliteprodev/rtc-simple-server
that referenced
this pull request
May 17, 2023
eliteprodev
added a commit
to eliteprodev/rtc-simple-server
that referenced
this pull request
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.