avoid adding stuffing in without_header test #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the without_header test had a mismatch in the header Packet length vs the number of bytes actually in the pes data.
At first I tried to make them match, but that caused a ton of test failures:
In the end it was simpler to remove the stuffing from the without_header test case.
The tests pass either way, but this discrepancy caused failures in some new tests I'm trying to add.