Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add status method-raise level to will change when there are diffs #587

Merged
merged 2 commits into from
Jan 11, 2017

Conversation

arichardet
Copy link
Contributor

A new method on status RaiseLevelForDiffs checks if there are any diffs and raises the level to StatusWillChange.
Resources were updated to call this new method in the following cases:

  • The same check was being performed prior to raising the level to StatusWillChange
  • Multiple calls to AddDifference/RaiseLevel to StatusWillChange: the calls to RaiseLevel were removed and a call to this new method was added at the end of the function.

Implements #586

Copy link
Contributor

@rebeccaskinner rebeccaskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a line into resource-authors-guide.md talking about the new function? LGTM otherwise.

Copy link
Contributor

@rebeccaskinner rebeccaskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rebeccaskinner rebeccaskinner merged commit f21bfd7 into master Jan 11, 2017
@rebeccaskinner rebeccaskinner deleted the feature/raise-level-for-diffs branch January 11, 2017 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants