plan: test, which illustrate "return nil, err" problem #336
Conversation
| Status string | ||
| Level resource.StatusLevel | ||
| Error error | ||
| NilAndError bool |
There was a problem hiding this comment.
I wonder if it would make more sense to have a type NilTask struct that just returns nil, error to keep the code clean
avnik
force-pushed
the
bug/return-nil-err
branch
from
175ed11
to
0cab19e
Compare
|
@rebeccaskinner I add commit with fix, ad can rework test, if you or @BrianHicks prefer it. This fix need to be merged before lvm branch |
| @@ -108,6 +108,11 @@ func (g *pipelineGen) PlanNode(taski interface{}) (interface{}, error) { | |||
| } | |||
| status, err := twrapper.Task.Check(renderer) | |||
|
|
|||
| // create empty Status structure, if it not created in .Check() | |||
avnik
force-pushed
the
bug/return-nil-err
branch
from
0cab19e
to
0494335
Compare
| return nil, errors.New("apply error") | ||
| } | ||
|
|
||
| // NilAndError return a FakeTask that will simulate `return nil, err` cawe |
|
|
||
| require.NoError(t, g.Validate()) | ||
|
|
||
| // applying should return error, and not panicking |
There was a problem hiding this comment.
// Apply should return an error and not panic
| @@ -105,6 +105,20 @@ func TestApplyStillChange(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestApplyNilError(t *testing.T) { | |||
There was a problem hiding this comment.
add comments on exported methods (will fix cc issues)
| @@ -45,6 +45,21 @@ func TestPlanNoOp(t *testing.T) { | |||
| assert.Equal(t, task, result.Task) | |||
| } | |||
|
|
|||
| func TestPlanNilAndError(t *testing.T) { | |||
There was a problem hiding this comment.
add comments on exported methods
| @@ -65,6 +65,25 @@ func WillChange() *FakeTask { | |||
| } | |||
| } | |||
|
|
|||
| // Task which always return (nil, error) tuple | |||
There was a problem hiding this comment.
fix comments on these. see https://codeclimate.com/github/asteris-llc/converge/pull/336
avnik
force-pushed
the
bug/return-nil-err
branch
2 times, most recently
from
a73ec6b
to
0a1ffed
Compare
avnik
changed the title
|
@rebeccaskinner @ryane all test are green now. |
avnik
force-pushed
the
bug/return-nil-err
branch
from
0a1ffed
to
611ec9f
Compare
plan: test, which illustrate "return nil, err" problem
No description provided.