Refactor deserializers #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianHicks
force-pushed
the
feature/lists-in-params
branch
2 times, most recently
from
7617910
to
59703ad
Compare
|
Just to track: this is a partial fix for #110 |
BrianHicks
force-pushed
the
feature/lists-in-params
branch
from
6ea1350
to
55bc298
Compare
This was referenced Oct 3, 2016
Merged
stevendborrelli
added a commit
that referenced
this pull request
Oct 5, 2016
stevendborrelli
added a commit
that referenced
this pull request
Oct 6, 2016
stevendborrelli
added a commit
that referenced
this pull request
Oct 11, 2016
stevendborrelli
added a commit
that referenced
this pull request
Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to render things in serializers. See the updated module author's guide for how the struct tags are now used.
Next step: letting users user more complex values in params.