-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to indicate the group name when adding a user #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just one question
@@ -93,10 +104,17 @@ func (u *User) Check(resource.Renderer) (resource.TaskStatus, error) { | |||
|
|||
switch { | |||
case userByName != nil: | |||
status.Level = resource.StatusFatal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this case no longer fatal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should not have been fatal. With state=present, if the user exists, we do not change.
LGTM on green |
Add ability to indicate the group name when adding a user
Can now add a user by specifying either the group name or gid.