Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell module should not set StatusLevel based on process exit code #323

Closed
ryane opened this issue Sep 28, 2016 · 0 comments · Fixed by #324
Closed

shell module should not set StatusLevel based on process exit code #323

ryane opened this issue Sep 28, 2016 · 0 comments · Fixed by #324
Assignees
@ryane
Labels
bug
Milestone
0.3.0

Comments

@ryane
Copy link
Contributor

ryane commented Sep 28, 2016

Right now, the exit code of a shell command can dictate what StatusLevel is returned from StatusCode. So, if you have a shell command that returns an exit code of 4, StatusCode() incorrectly returns StatusFatal [1]. Shouldn't StatusCode just report StatusWillChange if the command did execute but returned anything other than 0?

[1] This currently does not have any effect but it probably should. See #322
@ryane ryane added the bug label Sep 28, 2016
@ryane ryane self-assigned this Sep 28, 2016
@BrianHicks BrianHicks added this to the 0.3.0 milestone Sep 28, 2016
ryane added a commit that referenced this issue Sep 28, 2016
@ryane
shell: non-0 exit code returns StatusWillChange
9256a60 
fixes #323
ryane added a commit that referenced this issue Sep 28, 2016
@ryane
shell: non-0 exit code returns StatusWillChange
18ac43b 
fixes #323
@ryane ryane mentioned this issue Sep 28, 2016
Merged
BrianHicks pushed a commit that referenced this issue Dec 22, 2016
@ryane
shell: non-0 exit code returns StatusWillChange
e41cd96 
fixes #323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryane ryane

Labels
bug
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

shell: non-0 exit code returns StatusWillChange asteris-llc/converge
2 participants
@ryane @BrianHicks