pretty printed changes should align values

[stevendborrelli]

the changes output arrows should line up. Currently they are staggered:

root/file.file1:
    Messages:
    Has Changes: yes
    Changes:
        content:
        before:

        after:
            this is a test
            of the content module

        gid: "" => "20"
        group: "" => "staff"
        type: "" => "file"
        uid: "" => "501"
        username: "" => "steve"

This is a minor issue, but reformat output so that => arrows line up.

[BrianHicks]

Clarification: do you want them lined up after the colon or after the value? (I vote after the colon)

Colon

        gid:      "" => "20"
        group:    "" => "staff"
        type:     "" => "file"
        uid:      "" => "501"
        username: "" => "steve"

Value

        gid: ""      => "20"
        group: ""    => "staff"
        type: ""     => "file"
        uid: ""      => "501"
        username: "" => "steve"

[BrianHicks]

Colons also look better when the values are different sizes:

        gid:      "" => "20"
        group:    "" => "staff"
        type:     "" => "file"
        uid:      "" => "501"
        username: "brian" => "steve"

[stevendborrelli]

colon, but we need to see what it looks like when diffs are applied.

[rebeccaskinner]

Do we want to essentially columnize the output by left-justifying what comes before the arrow?

    gid:           "" => "20"
    group:         "" => "staff"
    type:          "" => "file"
    uid:           "" => "501"
    username: "brian" => "steve"

On Sep 13, 2016, at 11:56 AM, Brian Hicks [email protected] wrote:

Colons also look better when the values are different sizes:

    gid:      "" => "20"
    group:    "" => "staff"
    type:     "" => "file"
    uid:      "" => "501"
    username: "brian" => "steve"

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #244 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AAMbq8h01simDOIClgyry5ypOxEBzbG6ks5qptWxgaJpZM4J75qQ.

[BrianHicks]

that was my thought, yes

[BrianHicks]

Sorry for the noise about the title. I think Waffle is doing something odd.

[sehqlr]

What was the color on the bike shed on this one? I think that we decided on something, but I don't know if it was written down anywhere.

[BrianHicks]

Definitely a compile flag.

...

Just kidding it's gonna be after the colon / before the arrow.

[sehqlr]

I'm going to remove from the 0.3.0 project, so we only track the PR