Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution Engine Ignoring Warning Levels #243

Closed
Dacode45 opened this issue Sep 13, 2016 · 3 comments · Fixed by #256
Closed

Execution Engine Ignoring Warning Levels #243

Dacode45 opened this issue Sep 13, 2016 · 3 comments · Fixed by #256
Assignees
Labels
Milestone

Comments

@Dacode45
Copy link
Contributor

If a fatal error happens during a check or apply I do the following.

if err != nil {
            t.Status = &resource.Status{
                WarningLevel: resource.StatusFatal,
                Status:       err.Error(),
            }
            return t.Status, err

When I run converge plan expecting to see an error I get the following output

root/systemd.unit.test:
    Messages:
    Has Changes: no
    Changes: No changes
@BrianHicks
Copy link
Contributor

minor feedback: apparently Status is not used much of anywhere, and appending to Output is better. Just FYI.

@BrianHicks
Copy link
Contributor

Silly GitHub, closin' the issues

@BrianHicks BrianHicks added this to the 0.2.0-beta2 milestone Sep 19, 2016
@rebeccaskinner
Copy link
Contributor

@Dacode45 was this the issue that you fixed in: 3858811 ? If not can you validate that it's still a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants