Household hp ac ts ev #405
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o building_heatpump_DR_integration
…/assume-framework/assume into building_heatpump_DR_integration
-fixed components
-adjusted the bidding strategy
…/assume-framework/assume into building_heatpump_DR_integration
…/assume-framework/assume into building_heatpump_DR_integration
…esidential sector
…o household_HP_AC_TS_EV
…o household_HP_AC_TS_EV
| ) | ||
|
|
||
| self.electricity_price = self.forecaster["price_EOM"] | ||
| self.natural_gas_price = self.forecaster["fuel_price_natural_gas"] |
There was a problem hiding this comment.
fuel_price_natural_gas needs to be called fuel_price_natural gas since in the input file it is written natural gas too. Or the csv_loader gets adapted such that it replaces whitespaces with "_".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
Closes #[issue number] (if applicable)
Description
[Provide a brief description of the changes in this PR]
Changes Proposed
Testing
[Describe the testing you've done, including any specific test cases or scenarios]
Checklist
Please check all applicable items:
docfolder updates)pyproject.tomldoc/release_notes.rstof the upcoming release is includedAdditional Notes (if applicable)
[Any additional information, concerns, or areas you want reviewers to focus on]
Screenshots (if applicable)
[Add screenshots to demonstrate visual changes]