Update meteor to 1.8.1 #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Meteor to 1.8.1 (RocketChat#15358) * Meteor update to 1.8.1 meteor update meteor update --all-packages * Remove deprecated rocketchat:monitoring package * Fix calling WebAppInternals.staticFilesMiddleware new signature * Update Node version to 8.15 * Clear main files to cache some build files * Meteor npm install
jschirrmacher
previously approved these changes
Sep 19, 2019
jschirrmacher
left a comment
jschirrmacher
left a comment
There was a problem hiding this comment.
Since this is a cherry-pick from RC standard repo, I assume this will work as expected.
Not completely (including dependencies) in order to avoid merge conflict when merging 2.0 lateron (which also removes GraphQL)
Member
Author
|
@jschirrmacher the commit I cherry-picked unfortunately contained dependencies: GraphQL-support in the package-dependencies was removed with the same commit, but not dependent files. Thus, I had to removed this in separate commits. |
jschirrmacher
approved these changes
Sep 20, 2019
jschirrmacher
left a comment
jschirrmacher
left a comment
There was a problem hiding this comment.
Ok. I don't know why exactly we don't want to have GraphQL in Assistify, but I suppose we actually don't need it.
It would be cool, if the tests wouldn't depend on the order of the sections, but this might be another issue, so I approve again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry pick of a0d8658 which is included in Rocket.Chat 2.1
This not only brings the latest Meteor release, but also adapts CircleCI so that memory issues during build should not happen anymore
Update Meteor to 1.8.1 (RocketChat#15358)
meteor update
meteor update --all-packages
Remove deprecated rocketchat:monitoring package
Fix calling WebAppInternals.staticFilesMiddleware new signature
Update Node version to 8.15
Clear main files to cache some build files
Meteor npm install
Closes #ISSUE_NUMBER