-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Issues 87, 88 (livechat on mobile devices) #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm in general.
Since most changes are @media
-prefixed, I don't see much impact on the rest.
@HenrikScholl For the non-@media-places, I would like to get your feedback what's the motivation and impact.
@@ -47,7 +47,6 @@ <h1>{{title}}</h1> | |||
{{> offlineForm (offlineData)}} | |||
</div> | |||
{{/if}} | |||
{{> poweredBy }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HenrikScholl can you please explain why you moved the poweredBy
from here to the multiple other places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed that, because I set the fix position to the Input-Form.
In the Offline-Version is no Input-Form, so the "Powered by"-Logo has the wrong Postion
@@ -774,6 +928,8 @@ input:focus { | |||
opacity: 0.5; | |||
align-self: flex-end; | |||
transition: opacity 0.15s ease-out; | |||
bottom: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HenrikScholl what's the effect if this is not set?
Should/Could this also be limited to @media @smartphones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Code set a fix postion to the Chat Input-Form (Issue 88)
@HenrikScholl unfortunately, I only verified the In general, it looks as if the Reverting now, please correct and create a new PR. |
@HenrikScholl we had to revert the PR since it affects the regular Live-Chat window. |
Livechat on mobile devices
Closes #87
closes #88