Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issues 87, 88 (livechat on mobile devices) #162

Merged
merged 1 commit into from
Dec 6, 2017

Conversation

HenrikScholl
Copy link

@HenrikScholl HenrikScholl commented Dec 6, 2017

Livechat on mobile devices

Closes #87
closes #88

@ghost ghost assigned HenrikScholl Dec 6, 2017
@ghost ghost added the progress:working label Dec 6, 2017
Copy link
Member

@mrsimpson mrsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general.
Since most changes are @media-prefixed, I don't see much impact on the rest.
@HenrikScholl For the non-@media-places, I would like to get your feedback what's the motivation and impact.

@@ -47,7 +47,6 @@ <h1>{{title}}</h1>
{{> offlineForm (offlineData)}}
</div>
{{/if}}
{{> poweredBy }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HenrikScholl can you please explain why you moved the poweredBy from here to the multiple other places?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed that, because I set the fix position to the Input-Form.
In the Offline-Version is no Input-Form, so the "Powered by"-Logo has the wrong Postion

@@ -774,6 +928,8 @@ input:focus {
opacity: 0.5;
align-self: flex-end;
transition: opacity 0.15s ease-out;
bottom: 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HenrikScholl what's the effect if this is not set?
Should/Could this also be limited to @media @smartphones

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Code set a fix postion to the Chat Input-Form (Issue 88)

@mrsimpson mrsimpson merged commit 70efa4f into develop Dec 6, 2017
@ghost ghost removed the progress:working label Dec 6, 2017
@mrsimpson mrsimpson deleted the feature/livechat-integration branch December 6, 2017 14:03
@mrsimpson mrsimpson changed the title Fixed Issues 87, 88 Fixed Issues 87, 88 (livechat on mobile devices) Dec 7, 2017
@mrsimpson mrsimpson restored the feature/livechat-integration branch December 7, 2017 09:28
@mrsimpson mrsimpson deleted the feature/livechat-integration branch December 7, 2017 09:28
@mrsimpson
Copy link
Member

@HenrikScholl unfortunately, I only verified the /livechat/- display before merging it.
The actual livechat-widget is negatively affected (cut off at the bottom) by the changes:

offline livechat
livechat online

In general, it looks as if the @media was not properly respected: On my desktop's browser, the fonts are much larger now:
livechat maximized

Reverting now, please correct and create a new PR.

@ruKurz
Copy link

ruKurz commented Dec 7, 2017

@HenrikScholl we had to revert the PR since it affects the regular Live-Chat window.
Please have a look at: #164
and create a new PR after fixing that issue.

@HenrikScholl HenrikScholl restored the feature/livechat-integration branch January 4, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style bug in livechat fullscreen on mobile device Redesign livechat window on mobile device
3 participants