Fix reporting of errors in JavaScript assets that use module-exclusiv…

…e features Munter/netlify-plugin-checklinks#286 (comment)
assetgraph · Nov 11, 2020 · 5174cd0 · 5174cd0
1 parent 19024af
commit 5174cd0
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 3 deletions.
diff --git a/lib/assets/JavaScript.js b/lib/assets/JavaScript.js
@@ -235,11 +235,16 @@ class JavaScript extends Text {
           this._parse(text, 'script');
           parsedAsScript = true;
         } catch (errorParsingAsScript) {
-          const message = `Parse error in ${this.urlOrDescription}\n${errorParsingAsScript.message}`;
+          const errorToReport = /sourceType: module/.test(
+            errorParsingAsScript.message
+          )
+            ? errorParsingAsModule
+            : errorParsingAsScript;
+          const message = `Parse error in ${this.urlOrDescription}\n${errorToReport.message}`;
           const err = new errors.ParseError({
             message,
-            line: errorParsingAsScript.lineNumber,
-            index: errorParsingAsScript.index,
+            line: errorToReport.lineNumber,
+            index: errorToReport.index,
             asset: this,
           });
           if (this.assetGraph) {

diff --git a/test/assets/JavaScript.js b/test/assets/JavaScript.js
@@ -44,6 +44,21 @@ describe('assets/JavaScript', function () {
     );
   });
 
+  // https://github.com/Munter/netlify-plugin-checklinks/issues/286#issuecomment-725530864
+  it('should report a syntax error in a JavaScript asset that uses module features', async function () {
+    let firstWarning;
+    await new AssetGraph({
+      root: pathModule.resolve(__dirname, '../../testdata/assets/JavaScript/'),
+    })
+      .on('warn', (err) => (firstWarning = firstWarning || err))
+      .loadAssets('parseErrorAndModuleFeatures.js')
+      .populate();
+
+    expect(firstWarning, 'to be an', Error);
+    expect(firstWarning.message, 'to match', /Unexpected token/);
+    expect(firstWarning.message, 'to contain', '(2:18)');
+  });
+
   it('should handle setting a new parseTree', function () {
     const one = new AssetGraph().addAsset({
       type: 'JavaScript',

diff --git a/testdata/assets/JavaScript/parseErrorAndModuleFeatures.js b/testdata/assets/JavaScript/parseErrorAndModuleFeatures.js
@@ -0,0 +1,2 @@
+import { Component } from 'https://unpkg.com/preact?module';
+class Foo { state = {}; }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		import { Component } from 'https://unpkg.com/preact?module';
		class Foo { state = {}; }