-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
major rework - don't merge yet! #43
base: master
Are you sure you want to change the base?
Conversation
Conflicts: app/index.js package.json
💯 themes? 1000X 👍 |
what do you think so far @hariadi? I think the structure and flow is feeling pretty good, so I can start working on actual templates/content next. |
👍 I'm working on configstore in my local. It's ok with current structure? |
Ahhh.. I see you already use configstore. 👍 |
yeah, it seems to work great. basically it just saves a few values from the previous run. any time you change one of those values, you will be presented with the new value(s) on the next run. |
* adds basic theme and site scaffold * adds blog theme for blog page * adds several UI components * adds disqus include and placeholder config * uses `git clone` instead of bower to download bootstrap * adds navigation plugin and resolve helper *
* externalizes `setup` grunt task, and have it self-delete after first run * adds two starter themes * additional less components * helpers: webfonts, analytics * plugins: navigation, wordcount
…browser scripts than node.js javascript
add verbalize to deps
Hey @jonschlinkert and @hariadi if there is anything I can do to help out here, I would be happy to. I could work on LESS and Sass support as requested in #48 as well as Foundation 5 support as requested in #46. |
@pburtchaell awesome, that would be great! on a related note, might be good to do a skype call or something to update you on what we're planning in general |
Certainly @jonschlinkert. I will be on vacation from tomorrow to August 10 so I'll be fairly free; send me an email at [email protected] or a DM on Twitter and we can plan out a call. |
@pburtchaell sounds like a plan! |
So my thoughts are to split the generator several parts:
What do you think everyone? |
Well, we might want to hold off until we release the next version. Actually related to the call I mentioned. Have you seen the pr? Sent from my iPhone
|
I did not actually... for some reason I assumed it wasn't a major change because of the small # of commits, but I just checked out the PR. Looks good. And yeah, we can discuss on a call. |
I'd love to see #46 👍 |
I just wanted to get this pushed up. we can leave the pr open until everyone things it's good to merge.
There is a lot here, but the main thing I focused on was subgenerators. I started documentation for them, but not all of them have been created. Since @doowb already put the helper/plugin generators together, it might be good to use those somehow when a user runs
yo assemble:helper
etc. But I'm not sure how that works yet.Also, I probably broke the gruntfile! sorry @hariadi, I haven't had a chance to test or fix issues - I'm still working on this.
If anyone else wants to add to this pr, with templates, tests, fixes, whatever, please do!!! Let's make this a first class generator! (I might even add themes!)