Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Mark EditorHints as obsolete, it's no longer used by tooling. #780

Closed
NTaylorMullen opened this issue Jun 9, 2016 · 8 comments
Closed

Mark EditorHints as obsolete, it's no longer used by tooling. #780

NTaylorMullen opened this issue Jun 9, 2016 · 8 comments
Assignees
@NTaylorMullen
Labels
3 - Done bug
Milestone
1.1.0-preview1

Comments

@NTaylorMullen
Copy link
Contributor

No description provided.

@Eilon
Copy link
Member

Eilon commented Jul 7, 2016

You mean the EditorBrowsable stuff?

@Eilon
Copy link
Member

Eilon commented Jul 7, 2016

Also what does "no longer used" mean? Was it ever?

@NTaylorMullen
Copy link
Contributor Author

Nope, not EditorBrowsable, this. Talked to @anurse a while back and they were originally added to indicate if an attribute value was virtual; at which point Todd would detect that and provide appropriate ~/ IntelliSense. Thing is, Todds HTML editor is a bit more decoupled from the Razor side of things so he ended up taking his own stab at making that possible. End result, they were never used.

@dougbu
Copy link
Member

dougbu commented Jul 8, 2016

So is this a suggestion to [Obsolete] the unread / unset SpanEditHandler.EditorHints property? Or do you want to treat that class as if it were internal?

@NTaylorMullen
Copy link
Contributor Author

I'd prefer to treat it as if it was internal but that'd be a binary breaking change. I'm assuming that's a no go. Therefore, obsolete until we can remove it in a bigger release would suffice.

@Eilon Eilon added this to the 1.1.0 milestone Jul 22, 2016
@Eilon
Copy link
Member

Eilon commented Jul 22, 2016

Bug is approved as a breaking change. Please mark things obsolete (but remain compatible) in this bug, then log a new breaking-change bug for 2.0.0.

@Eilon
Copy link
Member

Eilon commented Jul 22, 2016

Breaking change guidelines: https://github.com/aspnet/Home/wiki/Engineering-guidelines#breaking-changes

@NTaylorMullen NTaylorMullen changed the title Remove EditorHints, it's no longer used by tooling. Mark EditorHints as obsolete, it's no longer used by tooling. Jul 22, 2016
@NTaylorMullen NTaylorMullen mentioned this issue Jul 22, 2016
Closed
NTaylorMullen added a commit that referenced this issue Jul 29, 2016
@NTaylorMullen
Obsolete EditorHints.
a27dea5 
- For tests added grouped pragma warning disables to not pollute the test files with too many duplicate warning disable/restores.

#780
NTaylorMullen added a commit that referenced this issue Jul 29, 2016
@NTaylorMullen
Obsolete EditorHints.
1a167bc 
- For tests added grouped pragma warning disables to not pollute the test files with too many duplicate warning disable/restores.

#780
@NTaylorMullen NTaylorMullen mentioned this issue Jul 29, 2016
Merged
NTaylorMullen added a commit that referenced this issue Aug 1, 2016
@NTaylorMullen
Obsolete EditorHints.
fc4a615 
- For tests added grouped pragma warning disables to not pollute the test files with too many duplicate warning disable/restores.

#780
@NTaylorMullen
Copy link
Contributor Author

fc4a615

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done bug
Projects
None yet
Milestone
1.1.0-preview1
Development

No branches or pull requests
3 participants
@Eilon @NTaylorMullen @dougbu