Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

TagHelper directives don't work with optional quotes in non-import files #744

Closed
ryanbrandenburg opened this issue May 5, 2016 · 2 comments
Assignees
Milestone

Comments

@ryanbrandenburg
Copy link
Contributor

@addTagHelper *, Location will work in any location, and @addTagHelper "*, Location" will work in an _ImportView.cshtml, but if you try to do @addTagHelper "*, Location" in for example Index.cshtml you'll get an error saying "The given assembly name or codebase was invalid"

To reproduce, create a new Web project, copy the @addTagHelper directive out of _ViewImports.cshtml into Index.cshtml and change it to @addTagHelper "*, Microsoft.AspNetCore.Mvc.TagHelpers".

@Eilon Eilon added this to the 1.0.0 milestone May 9, 2016
@Eilon
Copy link
Member

Eilon commented May 9, 2016

@DamianEdwards FYI moving this to RTM.

NTaylorMullen added a commit that referenced this issue May 18, 2016
…directive text.

- Added a test with optional quotes for each of the `TagHelperDirectiveDescriptor`s, add, remove and prefix.

#744
NTaylorMullen added a commit that referenced this issue May 18, 2016
…directive text.

- Added a test with optional quotes for each of the `TagHelperDirectiveDescriptor`s, add, remove and prefix.

#744
NTaylorMullen added a commit that referenced this issue May 24, 2016
…directive text.

- Added a test with optional quotes for each of the `TagHelperDirectiveDescriptor`s, add, remove and prefix.

#744
@NTaylorMullen
Copy link
Contributor

80ebb4a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants