Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Cannot resolve TagHelperDesignTimeDescriptors in CoreCLR #709

Closed
NTaylorMullen opened this issue Mar 8, 2016 · 5 comments
Closed

Cannot resolve TagHelperDesignTimeDescriptors in CoreCLR #709

NTaylorMullen opened this issue Mar 8, 2016 · 5 comments
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Contributor

The impact of this bug is not having <summary> IntelliSense in the Razor editor.

Problem: RazorTooling currently only compiles for CoreCLR/netstandard and Razor ifdefs the design time descriptor code to only run in net45 (how it used to run).

We need to find a way to locate XML locations for assemblies in CoreCLR to make this possible.

@NTaylorMullen
Copy link
Contributor Author

/cc @danroth27 / @Eilon i'm working on this now feel free to decorate with whatever labels you feel necessary. Taskbughancement is my all encompassing suggestion.

@Eilon
Copy link
Member

Eilon commented Mar 8, 2016

Sorry, didn't feel like creating a new taskbughancement label 😄

@ToddGrun
Copy link

ToddGrun commented Mar 8, 2016

Taylor, will this also fix the missing OutputElementHint info?

@NTaylorMullen
Copy link
Contributor Author

Yes this will also fix that since it exists on the design time descriptor.

NTaylorMullen added a commit that referenced this issue Mar 16, 2016
- After discussion offline to maintain consistency we decided to also remove `CodeBase` fallback in the net451 scenario. This will keep CoreCLR and net451 scenarios more consistent.
- Removed `CodeBase` validation tests.
- Added `GetAssemblyLocation` extensibility point to enable proper testing of the `TagHelperDesignTimeDescriptorFactory`.

#709
NTaylorMullen added a commit that referenced this issue Mar 21, 2016
- After discussion offline to maintain consistency we decided to also remove `CodeBase` fallback in the net451 scenario. This will keep CoreCLR and net451 scenarios more consistent.
- Removed `CodeBase` validation tests.
- Added `GetAssemblyLocation` extensibility point to enable proper testing of the `TagHelperDesignTimeDescriptorFactory`.

#709
NTaylorMullen added a commit that referenced this issue Mar 21, 2016
- After discussion offline to maintain consistency we decided to also remove `CodeBase` fallback in the net451 scenario. This will keep CoreCLR and net451 scenarios more consistent.
- Removed `CodeBase` validation tests.
- Added `GetAssemblyLocation` extensibility point to enable proper testing of the `TagHelperDesignTimeDescriptorFactory`.

#709
@NTaylorMullen
Copy link
Contributor Author

3d0bf62

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants