Added nuspec file to Mvc.Analyzers assembly #7690
Conversation
| <dependencies> | ||
| <group targetFramework=".NETStandard1.3"> | ||
| <dependency id="Microsoft.CodeAnalysis.CSharp.Workspaces" version="2.6.1" exclude="Build,Analyzers" /> | ||
| <dependency id="NETStandard.Library" version="1.6.1" exclude="Build,Analyzers" /> |
There was a problem hiding this comment.
@natemcmaster confirming we don't need this reference. The project's going to get an implicit reference to a newer version anyway.
ajaybhargavb
force-pushed
the
ajbaaska/symbols-nupkg
branch
from
3deacfc to
fb21c95
Compare
| <repository type="git" url="$repositoryUrl$" commit="$repositoryCommit" /> | ||
| <dependencies> | ||
| <group targetFramework=".NETStandard1.3"> | ||
| <dependency id="Microsoft.CodeAnalysis.CSharp.Workspaces" version="$CodeAnalysisCSharpWorkspacesVersion$" exclude="Build,Analyzers" /> |
There was a problem hiding this comment.
Typically analyzer packages should have zero dependencies. Analyzer packages only deliver an analyzer binary, but shouldn't introduce dependencies to the app.
There was a problem hiding this comment.
This was already the case.
There was a problem hiding this comment.
You caught a bug. This dependency should have been PrivateAssets='All'. The references to roslyn are only used to produce the analyzer. They're not needed by the application's runtime in order to use the analyzer.
There was a problem hiding this comment.
Ah okay. I'll update it.
ajaybhargavb
force-pushed
the
ajbaaska/symbols-nupkg
branch
from
fb21c95 to
9b0d62b
Compare
|
Updated. |
ajaybhargavb
force-pushed
the
ajbaaska/symbols-nupkg
branch
from
9b0d62b to
8dc8590
Compare
| repositoryUrl=$(RepositoryUrl); | ||
| repositoryCommit=$(RepositoryCommit); | ||
| copyright=$(Copyright); | ||
| CodeAnalysisCSharpWorkspacesVersion=$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion); |
ajaybhargavb
force-pushed
the
ajbaaska/symbols-nupkg
branch
2 times, most recently
from
ef72609 to
43f6150
Compare
ajaybhargavb
force-pushed
the
ajbaaska/symbols-nupkg
branch
from
43f6150 to
595e83d
Compare
Part of aspnet/Universe#1083