This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Do not use FormattedModelValue in password editor template
#7430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dougbu
commented
Mar 2, 2018
dougbu
commented
- Password value: input vs editor #7418
- add quirk switch to reverse this if necessary
dougbu
commented
Mar 2, 2018
| { | ||
| static DefaultEditorTemplatesTest() | ||
| { | ||
| AppContext.SetSwitch("Switch.Microsoft.AspNetCore.Mvc.UsePasswordValue", true); |
Contributor
Author
There was a problem hiding this comment.
This was for local testing. I'll back the static constructor out.
NTaylorMullen
approved these changes
Mar 2, 2018
| } | ||
|
|
||
| [Fact] | ||
| public void PasswordTemplate_ReturnsInputElement_UsesHtmlAttributes() |
There was a problem hiding this comment.
This is really the only test you need. The others aren't directly related to this issue are they?
Contributor
Author
There was a problem hiding this comment.
FYI, I consolidated the other tests into PasswordTemplate_ReturnsInputElement_IgnoresValues(), setting everything in that. Mixing this one into that test case could be fooled by precedence between the value sources.
- #7418 - add quirk switch to reverse this if necessary
dougbu
force-pushed
the
dougbu/edit.password.7418
branch
from
437d1ac to
848266f
Compare
dougbu
added a commit
to aspnet/AspNetWebStack
that referenced
this pull request
Mar 3, 2018
- #135 - see also PR aspnet/Mvc#7430 - add quirk switch to reverse this if necessary
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.