This repository was archived by the owner on Dec 14, 2018. It is now read-only.
React to Microsoft.AspNetCore.Razor.Evolution => Microsoft.AspNetCore… #6105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTaylorMullen
requested review from
pranavkm,
rynowak,
ajaybhargavb and
ryanbrandenburg
NTaylorMullen
commented
Apr 7, 2017
| @@ -17,13 +17,13 @@ | |||
| "OldTypeId": "public interface Microsoft.AspNetCore.Mvc.Razor.Compilation.ICompilationService", | |||
| "OldMemberId": "Microsoft.AspNetCore.Mvc.Razor.Compilation.CompilationResult Compile(Microsoft.AspNetCore.Mvc.Razor.Compilation.RelativeFileInfo fileInfo, System.String compilationContent)", | |||
| "NewTypeId": "public interface Microsoft.AspNetCore.Mvc.Razor.Compilation.ICompilationService", | |||
| "NewMemberId": "Microsoft.AspNetCore.Mvc.Razor.Compilation.CompilationResult Compile(Microsoft.AspNetCore.Razor.Evolution.RazorCodeDocument codeDocument, Microsoft.AspNetCore.Razor.Evolution.RazorCSharpDocument cSharpDocument)", | |||
| "NewMemberId": "Microsoft.AspNetCore.Mvc.Razor.Compilation.CompilationResult Compile(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument codeDocument, Microsoft.AspNetCore.Razor.Language.RazorCSharpDocument cSharpDocument)", | |||
There was a problem hiding this comment.
@dougbu Will this be a problem or is this the correct way for our baselines to update?
There was a problem hiding this comment.
@NTaylorMullen I'm not sure what you mean. What does "this" refer to in your sentence?
E.g. if you're asking about changing existing exceptions, sure go right ahead and adjust them.
If you're asking about "Kind": "Modification", they're not long for this world. We will be thinking in strict "addition" and "removal" terms. (This is fine because API Check doesn't handle modifications correctly anyhow.) But, nobody has to get out in front of that change.
ryanbrandenburg
approved these changes
Apr 8, 2017
NTaylorMullen
force-pushed
the
nimullen/razor.razorlanguage.1169
branch
from
f9a2592 to
15abfa2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
….Razor.Language.
aspnet/Razor#1169