Update Library Manager build for net8 #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract TFMs that are likely to change into variables Update to net8 SourceLink is built into net8 SDK, can drop explciit references Update to net481, including source code references
jimmylewis
reviewed
Mar 11, 2024
jimmylewis
approved these changes
Mar 11, 2024
| <GeneratePackageOnBuild>True</GeneratePackageOnBuild> | ||
| <PackageId>Microsoft.Web.LibraryManager.Cli</PackageId> | ||
| <Description>Command line tool for Library Manager</Description> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Reference Include="System.Runtime" /> | ||
| <Reference Include="System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" /> |
There was a problem hiding this comment.
how does this version get resolved in the future? I.e. when updating to dotnet 10, will this break or does it get re-resolved to the version=10.0.0.0 assembly?
phil-allen-msft
force-pushed
the
dev/phil-allen-msft/libraryManagerBuildFix
branch
from
10fb005 to
3f5981c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Library Manager build for net8